ci: Build Docker for arm64 arch
#1423
Conversation
- Trivial upgrades: - docker/build-push-action@v5 => v6
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@joeyparrish do we need a CLA for a contribution that only touches the github workflows and not the actual code? |
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| with: | ||
| platforms: linux/amd64,linux/arm64 |
There was a problem hiding this comment.
Does this use qemu for emulation? How slow is it?
There was a problem hiding this comment.
Yes it does, and it's quite slow, took 1h on my gh action. Best would be to setup a matrix step on an external runner like you did on other actions but I can't setup this myself.
There was a problem hiding this comment.
I don't think I want to add 1h of emulated Docker builds to every PR. Let me try to set it up through our self-hosted runners, at least until GitHub starts offering Arm Linux runners publicly.
|
@joeyparrish I believe this might be accessible by a google project https://github.blog/changelog/2023-10-30-accelerate-your-ci-cd-with-arm-based-hosted-runners-in-github-actions/ |
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| with: | ||
| platforms: linux/amd64,linux/arm64 |
There was a problem hiding this comment.
I don't think I want to add 1h of emulated Docker builds to every PR. Let me try to set it up through our self-hosted runners, at least until GitHub starts offering Arm Linux runners publicly.
workflow_dispatchinbuild-docker.yamlfor better DXFor anyone willing to test the
armversion ➡️ https://hub.docker.com/r/peachoss/shaka-packager